Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the split package between the smallrye-reactive-messaging-jackson and smallrye-reactive-messaging-jsonb modules #2272

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

cescoffier
Copy link
Contributor

Fix #2261

… and smallrye-reactive-messaging-jsonb modules
@cescoffier cescoffier added this to the 4.10.0 milestone Aug 22, 2023
@cescoffier
Copy link
Contributor Author

As it's not a public API, it's not a breaking change. More a cosmetic thing.

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Merging #2272 (257b6d2) into main (244d4d9) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 257b6d2 differs from pull request most recent head 4235861. Consider uploading reports for the commit 4235861 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2272      +/-   ##
============================================
+ Coverage     77.85%   77.94%   +0.08%     
- Complexity     3708     3750      +42     
============================================
  Files           302      312      +10     
  Lines         12389    12525     +136     
  Branches       1588     1597       +9     
============================================
+ Hits           9646     9762     +116     
- Misses         2020     2039      +19     
- Partials        723      724       +1     
Files Changed Coverage Δ
...eactive/messaging/json/jackson/JacksonMapping.java 42.85% <ø> (ø)
...ye/reactive/messaging/json/jsonb/JsonBMapping.java 100.00% <ø> (ø)

... and 20 files with indirect coverage changes

@cescoffier cescoffier force-pushed the fix-split-package-jackson-jsonb branch from 9d4379b to d3a7cff Compare August 23, 2023 12:26
@cescoffier cescoffier force-pushed the fix-split-package-jackson-jsonb branch from d3a7cff to 4235861 Compare August 24, 2023 06:36
@cescoffier cescoffier merged commit 773f2f2 into smallrye:main Aug 24, 2023
3 checks passed
@cescoffier cescoffier deleted the fix-split-package-jackson-jsonb branch September 27, 2023 08:44
@am-tribia
Copy link

Why is smallrye-reactive-messaging-jackson.jar missing /META-INF/beans.xml file? I get the following error when I use
smallrye-reactive-messaging-jms:4.10.0 and smallrye-reactive-messaging-jackson:4.10.0

ERROR [io.sma.rea.mes.jms] (executor-thread-1) SRMSG15800: Unable to send message to JMS: java.lang.NullPointerException: Cannot invoke "io.smallrye.reactive.messaging.json.JsonMapping.toJson(Object)" because "this.jsonMapping" is null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split package warning with -jackson or -jsonb libraries with Quarkus
3 participants